[webkit-reviews] review denied: [Bug 25171] It should be possible to manually set the name of an anonymous function : [Attachment 29451] Patch to add displayName property to functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 18:59:06 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Francisco Tolmasky
<tolmasky at gmail.com>'s request for review:
Bug 25171: It should be possible to manually set the name of an anonymous
function
https://bugs.webkit.org/show_bug.cgi?id=25171

Attachment 29451: Patch to add displayName property to functions
https://bugs.webkit.org/attachment.cgi?id=29451&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You shouldn't change the behaviour of Function.name you should make the
profiler do the work of checking for name vs displayName, or alternatively add
a displayName function to InternalFunction and call that.


More information about the webkit-reviews mailing list