[webkit-reviews] review granted: [Bug 25149] Geolocation should start timer after permission is granted : [Attachment 29425] Addresses Sam's review comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 10:28:39 PDT 2009


Sam Weinig <sam at webkit.org> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 25149: Geolocation should start timer after permission is granted
https://bugs.webkit.org/show_bug.cgi?id=25149

Attachment 29425: Addresses Sam's review comments.
https://bugs.webkit.org/attachment.cgi?id=29425&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>      
> +    static void startTimer(Vector<RefPtr<GeoNotifier> >&);

This doesn't need to be in the header.	You can just declare it static in the
cpp file.

Otherwise, r=me.


More information about the webkit-reviews mailing list