[webkit-reviews] review denied: [Bug 16122] When posting to these boards, all Safari users have "webkitformboundary-gibberish" appended to their name and message : [Attachment 28964] Proposed patch for bug ID 16122

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Bill Monk
<billmonk2 at gmail.com>'s request for review:
Bug 16122: When posting to these boards, all Safari users have
"webkitformboundary-gibberish" appended to their name and message
https://bugs.webkit.org/show_bug.cgi?id=16122

Attachment 28964: Proposed patch for bug ID 16122
https://bugs.webkit.org/attachment.cgi?id=28964&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I think the patch probably went unnoticed

Looks like that, sorry!

+	 WARNING: NO TEST CASES ADDED OR CHANGED

This line is just a reminder to the person making the patch, please remove it,
or replace with a short explanation of why a test is not possible, or better
yet, add a test. I realize that the behavior is random, but it's acceptable to
have tests that are not 100% reliable.

It's not often that I have a chance to say this, but I think that the ChangeLog
has a bit too much information - for a full discussion, one can always refer to
this bug.

This patch has a lot of tab characters, please replace them with spaces.

+	 // Note: it may be better to not restore the / character, based on the
regex escaping issues
+	 // documented in https://bugs.webkit.org/show_bug.cgi?id=16122// 

Yes, please remove the FIXME, and change this whole comment to just explain the
behavior.

The substance of the patch looks good.