[webkit-reviews] review granted: [Bug 25136] CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame : [Attachment 29412] patch v1 - simplistic null check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 10 17:12:39 PDT 2009


Darin Adler <darin at apple.com> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 25136: CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
https://bugs.webkit.org/show_bug.cgi?id=25136

Attachment 29412: patch v1 - simplistic null check
https://bugs.webkit.org/attachment.cgi?id=29412&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

If you can figure out how to do a regression test, that would be a great
addition. Also, it's much better when there are per-function comments, even for
a simple function like this one.


More information about the webkit-reviews mailing list