[webkit-reviews] review requested: [Bug 25136] CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame : [Attachment 29412] patch v1 - simplistic null check

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 25136: CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
https://bugs.webkit.org/show_bug.cgi?id=25136

Attachment 29412: patch v1 - simplistic null check
https://bugs.webkit.org/attachment.cgi?id=29412&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This is a very simple minded solution to the crash.  Other parts of
DocumentLoader are fairly careful to null test m_frame before using it, and
indeed removeSubresourceLoader null checks m_frame before using it (except in
the case here where it calls updateLoading).

I have been struggling to get a good layout test for this.  For some reason my
layout test appears to be rather flakey so I don't want to submit it just yet. 
I'll keep working on it.  I just wanted to share this patch for feedback.