[webkit-reviews] review requested: [Bug 24206] RTL: the underline of overflowed RTL link text in hyperlink only underlined partial of the text : [Attachment 29403] Patch 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 10 15:13:11 PDT 2009


Jeremy Moskovich <playmobil at google.com> has asked  for review:
Bug 24206: RTL: the underline of overflowed RTL link text in hyperlink only
underlined partial of the text
https://bugs.webkit.org/show_bug.cgi?id=24206

Attachment 29403: Patch 1
https://bugs.webkit.org/attachment.cgi?id=29403&action=review

------- Additional Comments from Jeremy Moskovich <playmobil at google.com>
This fixes the drawing code but I'd really appreciate some comments regarding
the math.

I'm entirely unclear on why we need to add m_x to ellipsisX to convert it into
the same coordinate system as x?

Thanks!


More information about the webkit-reviews mailing list