[webkit-reviews] review denied: [Bug 25132] help prevent crash in chromium event handling : [Attachment 29395] patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 25132: help prevent crash in chromium event handling
https://bugs.webkit.org/show_bug.cgi?id=25132

Attachment 29395: patch
https://bugs.webkit.org/attachment.cgi?id=29395&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just some styling nits.

> +This is some cleanup motivated by the  crash in http://crbug.com/9775 ,
which
> +happens because of calling window.open inside a window.onload handler. 
> +
> +These changes are just part of the fix, along with some asserts to help
prevent
> +breakage on future changes. 

We usually indent these to the same col as "Reviewed By".

> +	       // TODO(asargent) this check for hidden value being !empty is a
workaround for

TODO(asargent) -> FIXME:in WebKit world.

> +	       // Once the fix for that is pulled into chromium we can remove
the check here.
> +	       if (!object->GetHiddenValue(key).IsEmpty()) {
> +		 object->DeleteHiddenValue(getKey(listener->isInline()));
> +	       }

no brackets around one-liners.