[webkit-reviews] review granted: [Bug 25121] Upstream changes to handle error messages from V8 when running worker script. : [Attachment 29384] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jian Li
<jianli at chromium.org>'s request for review:
Bug 25121: Upstream changes to handle error messages from V8 when running
worker script.
https://bugs.webkit.org/show_bug.cgi?id=25121

Attachment 29384: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=29384&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
LGTM

> +    // Do the one-time initialization.
> +    static bool v8Initialized = false;
> +    if (!v8Initialized) {
> +	   // Tells V8 not to call the default OOM handler, binding code will
handle it.
> +	   v8::V8::IgnoreOutOfMemoryException();
> +	   v8::V8::SetFatalErrorHandler(reportFatalErrorInV8);
> +	   
> +	   v8::V8::AddMessageListener(handleConsoleMessage);
> +	   
> +	   v8Initialized = true;
> +    }

Is there really no worry about multiple threads running this code at the same
time?