[webkit-reviews] review granted: [Bug 25084] Upstream changes to support V8 bindings for XHR in worker context. : [Attachment 29342] Proposed Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 25084: Upstream changes to support V8 bindings for XHR in worker context.
https://bugs.webkit.org/show_bug.cgi?id=25084

Attachment 29342: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=29342&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems OK to me.  I'm not the be-all, end-all expert here, but this also looks
like an "intermediate step" towards better bindings, since not all is
upstreamed yet.  Having commetns closer to the actual logic would be more
helpful in some case, like the if (global.isEmpty()) having a comment right
before it saying *why* we return 0 there.

Or having a comment right next to the funny function names Find vs. find in the
.cpp file which explains that the Find version shoudl be removed ASAP.

In general, looks fine to my eyes.