[webkit-reviews] review granted: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 29326] a11ydynamictypes.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 21546: [GTK] ATK accessibility enhancements
https://bugs.webkit.org/show_bug.cgi?id=21546

Attachment 29326: a11ydynamictypes.patch
https://bugs.webkit.org/attachment.cgi?id=29326&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +static GType GetAtkInterfaceTypeFromWAIType(WAIType type)
> +{
> +  switch (type) {
> +    case WAI_ACTION:
> +	 return ATK_TYPE_ACTION;
> +    case WAI_STREAMABLE:
> +	 return ATK_TYPE_STREAMABLE_CONTENT;
> +    case WAI_EDITABLE_TEXT:
> +	 return ATK_TYPE_EDITABLE_TEXT;
> +    case WAI_TEXT:
> +	 return ATK_TYPE_TEXT;
> +  }
> +
> +  return G_TYPE_INVALID;
> +}

style foobar... four spaces please and the case labels should be on the same
height as the switch (consult the style guide I might be wrong about the
switch).


> +#define WAI_TYPE_NAME_LEN (30) /* Enough for prefix + 5 hex characters (max)
*/
> +    static char name[WAI_TYPE_NAME_LEN + 1];
> +    
> +    g_sprintf(name, "WAIType%x", interfaceMask);
> +    name[WAI_TYPE_NAME_LEN] = '\0';

nice improvement.  I have no idea where W should come from AI == a11y here?