[webkit-reviews] review requested: [Bug 24527] caret does not paint the first time you focus on a 0px right padding RTL div : [Attachment 29341] patch w/ Layout test (version 3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 8 12:08:35 PDT 2009


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 24527: caret does not paint the first time you focus on a 0px right padding
RTL div
https://bugs.webkit.org/show_bug.cgi?id=24527

Attachment 29341: patch w/ Layout test (version 3)
https://bugs.webkit.org/attachment.cgi?id=29341&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
Hi Simon,

Thanks for your review and pointing the font-size change to make pixel test
difference. Mitz also pointed to enlarge font-size before, but I did not try to
enlarge it extremely (font-size:1000% wont work).

The changes against version 2 patch are all in test part:
1. remove </script><script> in testing html file
2. increase font-size to "font-size:2000%" to show pixel test difference.

Could you please review it again? Thanks!

Xiaomei


More information about the webkit-reviews mailing list