[webkit-reviews] review granted: [Bug 25082] Clean up repaint logic when composited layers come and go : [Attachment 29317] Patch, changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 7 14:41:35 PDT 2009


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 25082: Clean up repaint logic when composited layers come and go
https://bugs.webkit.org/show_bug.cgi?id=25082

Attachment 29317: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=29317&action=review

------- Additional Comments from mitz at webkit.org
> +    if (!repaintContainer)
> +	   repaintContainer= m_renderView;

Missing space before the =.

> +    // Update the compositing state of the given layer. Returns true if that
state changed.
> +    bool updateLayerCompositingState(RenderLayer*, bool mustRepaint = true);


I would like to channel Darin Adler and suggest that you use an enum instead of
a bool.

r=me


More information about the webkit-reviews mailing list