[webkit-reviews] review requested: [Bug 25063] Refactor InspectorController to use ScriptState/Object : [Attachment 29315] Refactor InspectorController to use ScriptObject/State, v2.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 7 11:35:07 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked for review:
Bug 25063: Refactor InspectorController to use ScriptState/Object
https://bugs.webkit.org/show_bug.cgi?id=25063
Attachment 29315: Refactor InspectorController to use ScriptObject/State, v2.1
https://bugs.webkit.org/attachment.cgi?id=29315&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
WebCore/ChangeLog | 35 +++
WebCore/GNUmakefile.am | 1 +
WebCore/WebCore.pro | 1 +
WebCore/WebCore.vcproj/WebCore.vcproj | 4 +
WebCore/WebCore.xcodeproj/project.pbxproj | 4 +
WebCore/WebCoreSources.bkl | 1 +
.../bindings/js/JSInspectorControllerCustom.cpp | 2 +-
WebCore/bindings/js/ScriptFunctionCall.cpp | 20 ++-
WebCore/bindings/js/ScriptFunctionCall.h | 5 +-
WebCore/bindings/js/ScriptObject.cpp | 53 ++++-
WebCore/bindings/js/ScriptObject.h | 10 +
WebCore/bindings/js/ScriptState.cpp | 44 ++++
WebCore/bindings/js/ScriptState.h | 3 +
WebCore/inspector/ConsoleMessage.cpp | 4 +-
WebCore/inspector/InspectorController.cpp | 231 ++++++--------------
WebCore/inspector/InspectorController.h | 17 +-
16 files changed, 242 insertions(+), 193 deletions(-)
More information about the webkit-reviews
mailing list