[webkit-reviews] review denied: [Bug 24904] Disentangle standards mode CSS type check from content sniffing : [Attachment 29292] patchzor2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 23:23:38 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 24904: Disentangle standards mode CSS type check from content sniffing
https://bugs.webkit.org/show_bug.cgi?id=24904

Attachment 29292: patchzor2
https://bugs.webkit.org/attachment.cgi?id=29292&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +    String mimeType = response().httpHeaderField("Content-Type");
>      return mimeType.isEmpty() || equalIgnoringCase(mimeType, "text/css") ||
equalIgnoringCase(mimeType, "application/x-unknown-content-type");

This won't allow e.g. "text/css; charset=utf-8". We have an
extractMIMETypeFromMediaType() method to extract the MIME type from header
value.

By the way, could you please provide some examples of sites that serve CSS
resources without a Content-Type header? I'm surprised that there is a number
of those.


More information about the webkit-reviews mailing list