[webkit-reviews] review requested: [Bug 24168] RTL: Home/End key does not behave correctly in mixed bidi text in RTL document : [Attachment 29296] patch w/ Layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 24168: RTL: Home/End key does not behave correctly in mixed bidi text in
RTL document
https://bugs.webkit.org/show_bug.cgi?id=24168

Attachment 29296: patch w/ Layout test
https://bugs.webkit.org/attachment.cgi?id=29296&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
Looks like I can use the comparison of bidi resolver's lastRun() and
logicallyLastRun() to check whether the logic last node is the visual last node
or not. 

If a line is an RTL line and its visual last node is not the same as its logic
last node, its logic last node is its visual start node, such as bidi text in a
RTL div, or <div dir=rtl> abc <span dir="rtl"> efg hij </span> xyz </div>.
Otherwise, its logic last node is the same as its visual last node, such as 
<div dir=rtl> abc <span style="direction:rtl"> efg hij </span> xyz </div>.

The same applies to logic start node.

This patch fixes the attached 2 test cases: bidi text in RTL document and RTL
text with inline RTL element.

Please be noted:
1. I am fixing the home/end key in "move" + "right"/"left", not "move" +
"forward"/"backward".
But I think it should be fixed in "move" + "foward"/"backward".

2. All tests passed, but there are 22 tests with stderr output.
They looks like environment problem, and I do not think they are related to my
change.