[webkit-reviews] review cancelled: [Bug 25063] Refactor InspectorController to use ScriptState/Object : [Attachment 29291] Refactor InspectorController to use ScriptObject/State, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 6 16:36:24 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has cancelled Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 25063: Refactor InspectorController to use ScriptState/Object
https://bugs.webkit.org/show_bug.cgi?id=25063

Attachment 29291: Refactor InspectorController to use ScriptObject/State, v1
https://bugs.webkit.org/attachment.cgi?id=29291&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Good idea on hasNoValue -> !value. As for handleException -- you have reminded
me I need to be careful and get this straight. The idea was that any
set/get/call failures in Script* world use reportException, but this obviously
has some re-entrancy implications for ConsoleMessage::addToConsole. Updated
patch coming up.


More information about the webkit-reviews mailing list