[webkit-reviews] review granted: [Bug 21260] Unbounded memory growth when churning elements with anonymous event handler functions : [Attachment 29286] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted 's request for review:
Bug 21260: Unbounded memory growth when churning elements with anonymous event
handler functions
https://bugs.webkit.org/show_bug.cgi?id=21260

Attachment 29286: patch
https://bugs.webkit.org/attachment.cgi?id=29286&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    // If we're already marking this tree, then we can simply mark this
wrapper
> -    // by calling the base class; our caller is iterating the tree.
> +    // Nodes in a subtree are kept alive by the tree's root, so, if the root

> +    // is already marking the tree, we only need to mark ourselves.
>      if (root->inSubtreeMark()) {
>	   DOMObject::mark();
> +	   markEventListeners(node->eventListeners());
>	   return;
>      }

I find it a little strange that the comment says "only need to mark ourselves"
and the code says "call the base class mark and also call markEventListeners".
Is there a simple way to make the comment and code consistent?

Same issue earlier in the file, in the more complicated version that also calls
mark on the document wrapper.

r=me