[webkit-reviews] review granted: [Bug 24979] Avoid type-coercion into AtomicString in AtomicString methods : [Attachment 29268] updated patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Mike Belshe <mike at belshe.com>'s
request for review:
Bug 24979: Avoid type-coercion into AtomicString in AtomicString methods
https://bugs.webkit.org/show_bug.cgi?id=24979

Attachment 29268: updated patch
https://bugs.webkit.org/attachment.cgi?id=29268&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

We should eventually change these methods to take named enum constants instead
of booleans for caseSensitive  - a call like str.contains("foo", true) is quite
confusing, str.contains("foo", CaseSensitive) would be much better. But that's
definitely a separate issue.