[webkit-reviews] review requested: [Bug 25056] Make editing stop using Position::m_offset directly : [Attachment 29273] Make Position::m_offset private and fix callers to use either deprecatedEditingOffset() or offsetInContainer()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 6 02:07:58 PDT 2009
Eric Seidel <eric at webkit.org> has asked for review:
Bug 25056: Make editing stop using Position::m_offset directly
https://bugs.webkit.org/show_bug.cgi?id=25056
Attachment 29273: Make Position::m_offset private and fix callers to use either
deprecatedEditingOffset() or offsetInContainer()
https://bugs.webkit.org/attachment.cgi?id=29273&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/ChangeLog | 11 ++
.../assert-on-range-creation-expected.txt | 1 +
.../execCommand/assert-on-range-creation.html | 12 ++
WebCore/ChangeLog | 140 ++++++++++++++++++++
WebCore/WebCore.base.exp | 2 +
WebCore/dom/Position.h | 19 ++-
WebCore/dom/PositionIterator.h | 4 +-
WebCore/dom/Range.cpp | 19 +++-
WebCore/dom/Range.h | 4 +
WebCore/editing/ApplyStyleCommand.cpp | 90 +++++++------
WebCore/editing/BreakBlockquoteCommand.cpp | 8 +-
WebCore/editing/CompositeEditCommand.cpp | 34 +++---
WebCore/editing/DeleteSelectionCommand.cpp | 47 ++++----
WebCore/editing/Editor.cpp | 14 +-
WebCore/editing/InsertLineBreakCommand.cpp | 6 +-
.../editing/InsertParagraphSeparatorCommand.cpp | 14 +-
WebCore/editing/InsertTextCommand.cpp | 12 +-
WebCore/editing/MoveSelectionCommand.cpp | 6 +-
WebCore/editing/ReplaceSelectionCommand.cpp | 2 +-
WebCore/editing/SelectionController.cpp | 4 +-
WebCore/editing/TextIterator.cpp | 2 +-
WebCore/editing/TypingCommand.cpp | 10 +-
WebCore/editing/VisiblePosition.cpp | 46 +++----
WebCore/editing/VisibleSelection.cpp | 12 +-
WebCore/editing/htmlediting.cpp | 20 ++-
WebCore/editing/visible_units.cpp | 40 +++---
WebCore/page/AccessibilityObject.cpp | 2 +-
WebCore/page/AccessibilityRenderObject.cpp | 4 +-
WebCore/page/DOMSelection.cpp | 16 +-
WebCore/page/EventHandler.cpp | 2 +-
WebCore/page/Frame.cpp | 2 +-
WebCore/page/mac/AccessibilityObjectWrapper.mm | 4 +-
WebCore/rendering/RenderTextControl.cpp | 2 +-
WebCore/rendering/RenderTreeAsText.cpp | 6 +-
WebKit/mac/ChangeLog | 11 ++
WebKit/mac/WebView/WebFrame.mm | 7 +-
36 files changed, 424 insertions(+), 211 deletions(-)
More information about the webkit-reviews
mailing list