[webkit-reviews] review requested: [Bug 25033] dtoa.cpp segfaults with g++ 4.4.0 : [Attachment 29251] dtoaalias.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 4 02:44:29 PDT 2009

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25033: dtoa.cpp segfaults with g++ 4.4.0

Attachment 29251: dtoaalias.patch

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, I've tried to explain the issue the best I could in the ChangeLog. I've
tried to cover all codepaths, but I haven't actually tested them, just the
default one. Also, I have not changed the macros defined when YES_ALIAS is
defined, although that is unlikely to work with the changes in the code.

Sunspider works with the patch, and the crashers are gone. Unfortunately I
can't compare performance with the previous version, since it crashes the
browser, but I hope someone else will be able to do that.

More information about the webkit-reviews mailing list