[webkit-reviews] review granted: [Bug 24692] Allow ChromeClientChromium to access an HTML select element's menu items : [Attachment 29242] Update for handling Mac Chromium popups with native controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 3 14:26:36 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Paul Godavari
<paul at chromium.org>'s request for review:
Bug 24692: Allow ChromeClientChromium to access an HTML select element's menu
items
https://bugs.webkit.org/show_bug.cgi?id=24692

Attachment 29242: Update for handling Mac Chromium popups with native controls
https://bugs.webkit.org/attachment.cgi?id=29242&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   (WebCore::PopupContainer::showSelectPopup):

ChangeLog was not updated to match the function renaming.

Otherwise, LGTM


More information about the webkit-reviews mailing list