[webkit-reviews] review granted: [Bug 24648] Optimize TransformationMatrix : [Attachment 29214] Patch to optimize map functions for translations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 3 11:10:27 PDT 2009


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 24648: Optimize TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=24648

Attachment 29214: Patch to optimize map functions for translations
https://bugs.webkit.org/attachment.cgi?id=29214&action=review

------- Additional Comments from mitz at webkit.org
> +	   return FloatPoint(static_cast<float>(p.x() + m_matrix[3][0]),
static_cast<float>(p.y() + m_matrix[3][1]));

I slightly prefer casting the matrix element to float rather than casting the
coordinate to double, adding in doubles, and casting the result down to float.
r=me either way.


More information about the webkit-reviews mailing list