[webkit-reviews] review requested: [Bug 24551] [Qt] leaks in font-handling : [Attachment 29228] proposed patch - more clever solution

[bugzilla-daemon at webkit.org]

Kelemen Balázs <Kelemen.Balazs.3 at stud.u-szeged.hu> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 24551: [Qt] leaks in font-handling
https://bugs.webkit.org/show_bug.cgi?id=24551

Attachment 29228: proposed patch - more clever solution
https://bugs.webkit.org/attachment.cgi?id=29228&action=review

------- Additional Comments from Kelemen Balázs
<Kelemen.Balazs.3 at stud.u-szeged.hu>
There is a logical mistake in the previous patch: FontFallbackList::fontDataAt
gives back the SimpleFontData what has been created the first time without
taking care about what FontDescription the Font what it gets as parameter has.
I am not sure it is really a problem because the outputs of LayoutTests are
equivalents of what they are with a clean TOT build. I tried the tests in
css1/font_properties and in fonts by load and see them (because they fail even
with the clean build). However I made another solution what does not suffer
from this problem by transplanted some of the logic from FontCache.cpp to
FontFallbackListQt.cpp and made a mapping from FontDescription to the
SimpleFontData what we create and give back. I am not sure about what copyright
and license should I use for the new file and where should I put it - let we
discuss about it if you like the patch. Now there are 2 different solution for
the same problem - you can choose what is better. I would be very happy if we
could fix and close the bug somehow.