[webkit-reviews] review denied: [Bug 25023] [Qt]Eliminating a leak in QNetworkReplyHandler : [Attachment 29223] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Tamas Szirbucz
<Szirbucz.Tamas at stud.u-szeged.hu>'s request for review:
Bug 25023: [Qt]Eliminating a leak in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=25023

Attachment 29223: proposed patch
https://bugs.webkit.org/attachment.cgi?id=29223&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree that there's probably a leak, but the purpose of release() is to
transfer the ownership to the caller. If we don't reset m_reply to 0 a
subsequent call to release() will return a pointer to the object whos ownership
we transferred to the previous caller. In other words: I think the caller in
abort() for example should call deleteLater on the reply(). Does that work for
you?