[webkit-reviews] review granted: [Bug 24693] Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0 : [Attachment 28973] Revised patch based on feedback !

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 23:16:07 PDT 2009


Holger Freyther <zecke at selfish.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 24693: Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
https://bugs.webkit.org/show_bug.cgi?id=24693

Attachment 28973: Revised patch based on feedback !
https://bugs.webkit.org/attachment.cgi?id=28973&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +!contains(DEFINES, ENABLE_SVG=0) {
> +    !contains(DEFINES, ENABLE_SVG=.): DEFINES += ENABLE_SVG=1

this looks a bit weird but should still do what you wanted.


More information about the webkit-reviews mailing list