[webkit-reviews] review denied: [Bug 24988] The Webkit plugin mime type matching code should allow the wildcards : [Attachment 29209] Updated patch with the wildcard mime type matching behavior on the mac.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 17:38:35 PDT 2009


Darin Adler <darin at apple.com> has denied Ananta Iyengar <ananta at chromium.org>'s
request for review:
Bug 24988: The Webkit plugin mime type matching code should allow the wildcards
https://bugs.webkit.org/show_bug.cgi?id=24988

Attachment 29209: Updated patch with the wildcard mime type matching behavior
on the mac.
https://bugs.webkit.org/attachment.cgi?id=29209&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   if ([[[plugin performSelector:enumeratorSelector] allObjects]
containsObject:key]) {
> +	   if ([[[plugin performSelector:enumeratorSelector] allObjects]
containsObject:key] ||
> +	       [[[plugin performSelector:enumeratorSelector] allObjects]
containsObject:@"*"]) {

This is inefficient. We don't want to call allObjects twice. We should put the
result of allObjects into a local variable and then use it twice.


More information about the webkit-reviews mailing list