[webkit-reviews] review granted: [Bug 25004] Upstream V8EventListenerList for V8 bindings. : [Attachment 29195] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jian Li
<jianli at chromium.org>'s request for review:
Bug 25004: Upstream V8EventListenerList for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25004

Attachment 29195: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=29195&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebCore/bindings/v8/V8EventListenerList.h
...
> +    class V8EventListenerList {
> +    public:
> +	   static const size_t kMaxKeyNameLength = 254;

nit: This should be renamed to maxKeyNameLength.  Const variables should
be named just like regular variables :)

Otherwise, R+