[webkit-reviews] review denied: [Bug 25003] Do not compare OwnPtr to 0 in CachedResource. : [Attachment 29193] The patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 09:48:16 PDT 2009


Darin Adler <darin at apple.com> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 25003: Do not compare OwnPtr to 0 in CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=25003

Attachment 29193: The patch.
https://bugs.webkit.org/attachment.cgi?id=29193&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks wrong. Callers are supposed to compare OwnPtr to 0, and it's
supposed to work properly and efficiently. Why isn't it working? That's what
needs to be fixed, not call sites.


More information about the webkit-reviews mailing list