[webkit-reviews] review requested: [Bug 24989] Refactor InspectorResource to use ScriptObject/FunctionCall : [Attachment 29172] refactor InspectorResource to use ScriptObject/FunctionCall, v1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 1 12:18:36 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 24989: Refactor InspectorResource to use ScriptObject/FunctionCall
https://bugs.webkit.org/show_bug.cgi?id=24989

Attachment 29172: refactor InspectorResource to use ScriptObject/FunctionCall,
v1.
https://bugs.webkit.org/attachment.cgi?id=29172&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog				    |	76 ++++
 .../bindings/js/JSInspectorControllerCustom.cpp    |	14 +-
 WebCore/bindings/js/ScriptFunctionCall.cpp	    |	 6 +
 WebCore/bindings/js/ScriptFunctionCall.h	    |	 1 +
 WebCore/bindings/js/ScriptObject.cpp		    |	71 ++++
 WebCore/bindings/js/ScriptObject.h		    |	10 +
 WebCore/inspector/InspectorController.cpp	    |  434 +++-----------------
 WebCore/inspector/InspectorController.h	    |	16 +-
 WebCore/inspector/InspectorController.idl	    |	 4 +-
 WebCore/inspector/InspectorResource.cpp	    |  315 +++++++++++---
 WebCore/inspector/InspectorResource.h		    |  121 ++++--
 11 files changed, 571 insertions(+), 497 deletions(-)


More information about the webkit-reviews mailing list