[webkit-reviews] review granted: [Bug 24978] Add V8 custom bindings for Node insert/remove methods : [Attachment 29154] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 1 09:16:07 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mike Belshe
<mike at belshe.com>'s request for review:
Bug 24978: Add V8 custom bindings for Node insert/remove methods
https://bugs.webkit.org/show_bug.cgi?id=24978

Attachment 29154: patch
https://bugs.webkit.org/attachment.cgi?id=29154&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks good -- one question? For DOM exception handling, can we use the
throwError(ExceptionCode) helper from V8Proxy.h? It returns v8::Undefined(),
but that should still work. Right?


More information about the webkit-reviews mailing list