[webkit-reviews] review denied: [Bug 21244] rectangle fill with IntRect : [Attachment 23947] Detect pixel-aligned rect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 30 14:47:49 PDT 2008

Eric Seidel <eric at webkit.org> has denied Ariya Hidayat
<ariya.hidayat at trolltech.com>'s request for review:
Bug 21244: rectangle fill with IntRect

Attachment 23947: Detect pixel-aligned rect

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please review the webkit coding style:
http://webkit.org/coding/coding-style.htm and correct the errors in this patch.

Otherwise this looks fine.  I'd rather see "enclosing" called "enclosingRect"
since it's a rect. :)

I'm surprised Qt doesn't do this internally already.  CoreGraphics on mac os x
certainly does.  IMO this seems like a hack around deficiencies in the Qt API.

r- for the coding style violations.

More information about the webkit-reviews mailing list