[webkit-reviews] review granted: [Bug 21250] Rename updateContents to repaintContentRectangle and make it cross-platform : [Attachment 23949] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 21250: Rename updateContents to repaintContentRectangle and make it
cross-platform
https://bugs.webkit.org/show_bug.cgi?id=21250

Attachment 23949: Patch
https://bugs.webkit.org/attachment.cgi?id=23949&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I don't understand why Chrome is derived from HostWindow. That doesn't make
sense to me. I could see why Chrome would *have* a HostWindow* stored in it,
but it seems really strange to derive it from HostWindow. Maybe the right thing
would be private inheritance? Adding these new virtual functions to Chrome
makes it harder to understand the purpose of the Chrome class.

This new window-repaint-related stuff seems way too low level to me to be a
good addition to ChromeClient, but I guess it already had all this "backing
store" stuff in it.

r=me