[webkit-reviews] review granted: [Bug 21229] NetworkStateNotifier.h lacks a #include <windows.h> for PLATFORM(WIN) : [Attachment 23934] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 30 09:04:56 PDT 2008

Darin Adler <darin at apple.com> has granted Darin Fisher (Google)
<darin at chromium.org>'s request for review:
Bug 21229: NetworkStateNotifier.h lacks a #include <windows.h> for

Attachment 23934: v1 patch

------- Additional Comments from Darin Adler <darin at apple.com>

One thing we might want to be more standard about is which basic system headers
are handled by either the project file prefix or the "config.h" include file.
Those includes won't need to be added in each file that depends on them. I
thought <windows.h> was in that category. Also I thought we needed to set some
macros like NOMINMAX before including <windows.h> and it was a problem any time
the include was in a file "alone" like this.

But I'm not sure of either of those things, it's something we can clean up
later, and this seems fine if it's helpful for building Chrome.

More information about the webkit-reviews mailing list