[webkit-reviews] review granted: [Bug 21224] Store the callee ScopeChain, not the caller ScopeChain, in the call frame header : [Attachment 23922] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 29 16:36:36 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted 's request for
review:
Bug 21224: Store the callee ScopeChain, not the caller ScopeChain, in the call
frame header
https://bugs.webkit.org/show_bug.cgi?id=21224

Attachment 23922: patch
https://bugs.webkit.org/attachment.cgi?id=23922&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
There is a typo in the ChangeLog: "Exec::m_scopeChain" should be
"ExecState::m_scopeChain".

You should add a test for the big you say you fixed, but you told me you will
do that.

 + // FIXME: callerCodeBlock can be NULL.

You should make a bug for this and add the bug number to the FIXME.

 +	for ( ; exec; exec = exec->m_prev)

Most of these in our code are of the form "for (; " with no space between the
'(' and the ';'.

Other than that, r=me.


More information about the webkit-reviews mailing list