[webkit-reviews] review granted: [Bug 21200] Allow direct access to 'arguments' without using op_resolve : [Attachment 23899] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 28 19:45:35 PDT 2008
Maciej Stachowiak <mjs at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 21200: Allow direct access to 'arguments' without using op_resolve
https://bugs.webkit.org/show_bug.cgi?id=21200
Attachment 23899: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=23899&action=edit
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me
Some optional comments:
- consider renaming create_arguments to init_arguments (perhaps init should be
renamed to enter)
- in the parser, instead of comparing to "arguments" consider comparing to
GOBAL_DATA->propertyNames.arguments()
More information about the webkit-reviews
mailing list