[webkit-reviews] review denied: [Bug 21073] JS Debugger doesn't handle 'for' loops correctly : [Attachment 23848] The patch is a fix for correctly emitting debugging hooks in nodes.cpp.

[bugzilla-daemon at webkit.org]

Kevin McCullough <kmccullough at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 21073: JS Debugger doesn't handle 'for' loops correctly
https://bugs.webkit.org/show_bug.cgi?id=21073

Attachment 23848: The patch is a fix for correctly emitting debugging hooks in
nodes.cpp. 
https://bugs.webkit.org/attachment.cgi?id=23848&action=edit

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>
Looks good however be aware that this will not fully fix the issue described in
this bug.

It will keep #1 & #3, but regress #2 in that subsequent "continues" will hit
the break point each time through the loop, where in VS and XCode it would not.


It will improve #4 & #5 in that you can now step over to the line with the
conditional of the for loop but you cannot step into the initialize or
increment statements of the for loop.

This patch would be fine without fixing all of these issues, however it would
also be good if we had a manual test that exercised each of the statement nodes
so that we could see the behavior and check against regressions.

Please make a test.