[webkit-reviews] review denied: [Bug 19157] Inspector should support console.trace : [Attachment 23843] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 14:36:35 PDT 2008

Kevin McCullough <kmccullough at apple.com> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19157: Inspector should support console.trace

Attachment 23843: patch

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>
JSConsole::trace doesn't use the "arguments" argument.	Either remove the name
or the argument altogether.

In Console::trace use this->page() instead of checking the m_frame, we made a
helper to do this easier.

Also please file a bug that says we should include and name (program) and
(eval) nodes.

Also please edit 19229 to also give better names than (anonymous function) when

More information about the webkit-reviews mailing list