[webkit-reviews] review granted: [Bug 21116] Audio from <audio> or <video> element continues after tab is closed : [Attachment 23851] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 09:31:45 PDT 2008

Antti Koivisto <koivisto at iki.fi> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 21116: Audio from <audio> or <video> element continues after tab is closed

Attachment 23851: revised patch

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This should still be renamed to match variable name for consistency:

bool inPageCache() const { return !m_inActiveDocument; }

It should return the value without negation and call sites and should be
reversed instead. (or alternatively find a good variable name that is true when
inactive, m_inInactiveDocument sounds bad).

This is minor, r=me with or without the change.

More information about the webkit-reviews mailing list