[webkit-reviews] review granted: [Bug 20980] Split off uncommonly used data from Node similar to ElementRareData : [Attachment 23829] Oops

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 18:52:00 PDT 2008


Darin Adler <darin at apple.com> has granted David Smith <catfish.man at gmail.com>'s
request for review:
Bug 20980: Split off uncommonly used data from Node similar to ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=20980

Attachment 23829: Oops
https://bugs.webkit.org/attachment.cgi?id=23829&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+inline Node *Node::containerChildNode(unsigned index) const

Need to move the * to the left so it's next to the return value type name.

In Node.cpp:

-
+    
 // --------

This is showing up because you added spaces on a blank line.

+    if(b || hasRareData())

Need a space after the if before the parenthesis.

+    NodeRareData *data = ensureRareData();

+    NodeRareData *data = ensureRareData();

Need to move the * to the left so it's by the type name.

r=me


More information about the webkit-reviews mailing list