[webkit-reviews] review granted: [Bug 21113] r36771 caused www.nytimes.com to not display when you return to it using back/forward : [Attachment 23817] Patch #2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 25 13:10:01 PDT 2008
Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 21113: r36771 caused www.nytimes.com to not display when you return to it
using back/forward
https://bugs.webkit.org/show_bug.cgi?id=21113
Attachment 23817: Patch #2
https://bugs.webkit.org/attachment.cgi?id=23817&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
CSSRule* CSSRule::parentRule() const
{
- // FIXME: I believe this always returns 0.
- // A correct implementation would have to look farther up than just the
parent.
return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent())
: 0;
}
Why is this comment wrong. Isn't the parent almost always a style sheet, and
not a rule?
r=me
More information about the webkit-reviews
mailing list