[webkit-reviews] review denied: [Bug 21001] Starting transition after animation, when animation is finished, transition is wrong : [Attachment 23658] Patch, including LayoutTest file

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 21001: Starting transition after animation, when animation is finished,
transition is wrong
https://bugs.webkit.org/show_bug.cgi?id=21001

Attachment 23658: Patch, including LayoutTest file
https://bugs.webkit.org/attachment.cgi?id=23658&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
style:
 86		const RenderStyle *fromStyle = kfAnim ?
kfAnim->unanimatedStyle() : currentStyle;

Also, I personally prefer longer variable names than kfAnim.  Makes me think
you're trying to use hungarian notation and making a float constant named anim.
:)


Can't this just be a deleteAllValues(m_transitions) call?
5     for (CSSPropertyTransitionsMap::const_iterator it =
m_transitions.begin(); it != end; ++it)
 276	     delete it->second;

And this too:
deleteAllValues(finishedTransitions);

And again...
finishedAnimations

Seems m_fromStyle should maybe not be const...

Otherwise looks fine.

I think we should resolve the deleteAllValues issue before landing.