[webkit-reviews] review granted: [Bug 21084] Make concept of children cross-platform on ScrollView : [Attachment 23783] patch #2

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 21084: Make concept of children cross-platform on ScrollView
https://bugs.webkit.org/show_bug.cgi?id=21084

Attachment 23783: patch #2
https://bugs.webkit.org/attachment.cgi?id=23783&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
>+	  Reviewed by NOBODY (OOPS!).

I AM A SOMEBODY!

>+	  const HashSet<Widget*>* children() const { return &m_children; }

Ick,  But I guess this has been here a while.

>-	  void removeChild(Widget*);
>-
>+	  

Whitespace added.


Looks good.  I think the implementations of addChildPlatformWidget and
removeChildPlatformWidget should assert that the widget is a platform widget,
just to be safe.  

r=me