[webkit-reviews] review denied: [Bug 20287] [Gtk] disable plugins for gtk/directfb target : [Attachment 23702] updated per holger's feedback, updated .pc checks and introduce WTF_PLATFORM_X11

[bugzilla-daemon at webkit.org]

Alp Toker <alp at nuanti.com> has denied Eric Seidel <eric at webkit.org>'s request
for review:
Bug 20287: [Gtk] disable plugins for gtk/directfb target
https://bugs.webkit.org/show_bug.cgi?id=20287

Attachment 23702: updated per holger's feedback, updated .pc checks and
introduce WTF_PLATFORM_X11
https://bugs.webkit.org/attachment.cgi?id=23702&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
I think PLATFORM(X11) is a good direction since we may want to share plugin
code between more ports some day.

Will your checks still work using only #if PLATFORM(X11) without checking
GDK_WINDOWING_X11 at all? That would be cleaner.

This check is wrong:

+/* Windowing Systems */
+#if PLATFORM(GTK) && !PLATFORM(WIN) && !PLATFORM(DIRECTFB)
+#define WTF_PLATFORM_X11 1
+#endif
+

It should be PLATFORM(WIN_OS). But moreover, I'd prefer if we define this only
in the build system without touching Platform.h at all. This sounds like an
opportunity to start making use of AC_DEFINE in configure.ac

+   PKG_CHECK_MODULES(CAIRO, cairo-directfb >= $CAIRO_REQUIRED_VERSION)
+   PKG_CHECK_MODULES(GTK, gtk+-directfb-2.0 >= $GTK_REQUIRED_VERSION)

^ I Don't think we actually need to check for either of these packages, since
we don't actually use any cairo-directfb or gtk+-directfb-2.0 features
directly, even when DirectFB is the target. I don't mind strongly if we add
these checks though, your call.