[webkit-reviews] review granted: [Bug 21011] Need to clean up fix in PropertyWrapperGetter::equals a bit (and add test case) : [Attachment 23681] Patch, including LayoutTest file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 24 15:33:55 PDT 2008


Eric Seidel <eric at webkit.org> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 21011: Need to clean up fix in PropertyWrapperGetter::equals a bit (and add
test case)
https://bugs.webkit.org/show_bug.cgi?id=21011

Attachment 23681: Patch, including LayoutTest file
https://bugs.webkit.org/attachment.cgi?id=23681&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
if (!a && !b || a == b) is redundant.

if (!a && !b)
should be sufficient.

Another way to write this woudl be:

if (!a || !b)
    return (a == b);

but I think the two ifs as you've written it is more clear (After removing the
redundancy).


More information about the webkit-reviews mailing list