[webkit-reviews] review granted: [Bug 5727] We want to evaluate scripts in viewless documents : [Attachment 23746] Next iteration: updated to ToT, should address the lastest comments

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 5727: We want to evaluate scripts in viewless documents
https://bugs.webkit.org/show_bug.cgi?id=5727

Attachment 23746: Next iteration: updated to ToT, should address the lastest
comments
https://bugs.webkit.org/attachment.cgi?id=23746&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This:
 5175	  if (document) {
 5176	      // If a document was provided we need to initialize
 5177	      // the loader but should not create an empty document.
 5178	      frame->setDocument(document);
 5179	      frame->loader()->init(false);
 5180	  } else
 5181	      frame->init();
 5182 
 5183	  if (document)
 5184	      document->setFrame(frame.get());
can be one unified if block.  There is no need for a second if (document) block
there.

I don't think there shoudl be a setIsDummyFrame call.  Instead, there should be
a Frame::create() version which creates a dummy frame.

Does a frame ever need the ability to become a non-dummy?

Otherwise this looks great.