[webkit-reviews] review requested: [Bug 20092] Spelling markers positioned incorrectly in RTL text : [Attachment 23761] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 24 13:34:51 PDT 2008

Jeremy Moskovich <playmobil at google.com> has asked  for review:
Bug 20092: Spelling markers positioned incorrectly in RTL text

Attachment 23761: Updated patch.

------- Additional Comments from Jeremy Moskovich <playmobil at google.com>
* Added bug URL to changelog.
* Added expected results for pixel test
* Replaced a bunch of temp variables with one markerSpansWholeBox flag.
* Cleaned up typos and tabs.
* Removed svn:executable line from patch.
* Fixed existing m_x + tx bug that mitz pointed out, "tool tip"s now match up
with grammar markers.

Note: For some reason the grammar markers aren't drawn in the pixel test image

More information about the webkit-reviews mailing list