[webkit-reviews] review denied: [Bug 21071] JSCore SPI addition for reporting an object's non-GC allocated memory : [Attachment 23760] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 21071: JSCore SPI addition for reporting an object's non-GC allocated
memory
https://bugs.webkit.org/show_bug.cgi?id=21071

Attachment 23760: patch
https://bugs.webkit.org/attachment.cgi?id=23760&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 * API/JSBase.h: Filled in some missing function names.

Good, but separate. Probably should land separately (first?).

+	 * JavaScriptCore.xcodeproj/project.pbxproj:
+	 
+	 ^ Add the SPI.

Cute, but unconventional. Should we really use this style? How about just
having the comment in a paragraph with the filenames.

Why SPI and not API? Is this just a staging thing? It seems strange and not
helpful to make a whole new SPI.cpp file to put this function in if its SPI
status will change later.

The normal term for SPI in header files is "Private". The header a new SPI
function should go into is whatever header the function would go into if it was
API, but with "Private.h" at the end instead of ".h" or "Internal.h".

review- because JSSPI.h is not the right name for this header