[webkit-reviews] review granted: [Bug 15413] SVGElementInstance does not implement EventTarget : [Attachment 23734] Patch 1 - v2 - Corrected patch, contained unrelated things.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 15413: SVGElementInstance does not implement EventTarget
https://bugs.webkit.org/show_bug.cgi?id=15413

Attachment 23734: Patch 1 - v2 - Corrected patch, contained unrelated things.
https://bugs.webkit.org/attachment.cgi?id=23734&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
static inline instead of just "inline"

This will of course crash:
JSEventListener* jsListener = static_cast<JSEventListener*>(listener);
due to bug 21044.  Ideally that call should just be fixed to return jsNull() in
both instances instead of crashing. :(	But we can also do that as part of the
other bug.

Sadly we'll (chrome) have to write all this for v8 too, due to use of custom
bindings. :(

I don't think this is needed for Mail:
 594 - (void)addEventListener:(NSString*)type :(id <DOMEventListener>)listener
:(BOOL)useCapture
 595 {
 596	 // FIXME: this method can be removed once Mail changes to use the new
method <rdar://problem/4746649>
 597	 [self addEventListener:type listener:listener useCapture:useCapture];
 598 }

Mail isn't going to be getting at SVGElementInstances, is it?  I guess it could
unintentioanlly register listeners on svg <use> content?

Looks sane enough.