[webkit-reviews] review denied: [Bug 20664] [GTK] File names are not always encodable in UTF-8 : [Attachment 23441] Add filenameToString and filenameFromString to FileSystemGtk.cpp

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 20664: [GTK] File names are not always encodable in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=20664

Attachment 23441: Add filenameToString and filenameFromString to
FileSystemGtk.cpp
https://bugs.webkit.org/attachment.cgi?id=23441&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 87	    gchar* systemFilename =
filenameFromString(m_filename.utf8().data());

That can just be:
 87	    gchar* systemFilename = filenameFromString(m_filename);
or?

I think all the imported code from GLIB should live in a separate header/.cpp
pair, that way it can have its own special indentation for that file.  Although
I'm not sure that's really enough code (at least for is_valid) to really
justify needing to be copy/pasted from glib.