[webkit-reviews] review granted: [Bug 20989] Aguments constructor should put 'callee' and 'length' properties in a more efficient way : [Attachment 23699] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 23 03:10:15 PDT 2008


Oliver Hunt <oliver at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 20989: Aguments constructor should put 'callee' and 'length' properties in
a more efficient way
https://bugs.webkit.org/show_bug.cgi?id=20989

Attachment 23699: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=23699&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

I wonder if overrodeLength/overrodeCallee being bitfields is "expensive" -- did
you try without?

Also if you're trying to reduce size it might be worth seeing if you can drop
one of the other fields to 30 bits and so merge the bitfields.


More information about the webkit-reviews mailing list